Follow-up Comment #2, patch #5629 (project freeciv):

Sorry to comment only after this has been committed, but somehow I missed that
it's an effect earlier.

Do you have a specific reason you've made it an effect instead of single value
like similar igter_cost in terrain.ruleset? I don't see you needing the
flexibility of an effect (what requirements would change the value during the
game?). OTOH we may want to make the value to depend on action in question in
the future - while that would be trivial to extend to from a single value, at
least currently there's no way to make an effect to depend on which action
we're doing. Converting from an effect to any other system is practically
impossible, but the other way is easy. My gut feeling is that this should be
revisited before someone starts to use it (and at least before 2.6 format
freezes) but feel free to tell me that the current implementation is actually
needed.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?5629>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to