Follow-up Comment #2, patch #5760 (project freeciv):

>> I couldnt patch it with patch -p1
>> I patched with git apply and: ( idk if applied cleanly, it didnt wrote any
errors)
See `git apply -v` to find out why patch -p1 fails (was edited by hand to work
with S2_5). Will fix.

>> - in fast opened new game it screwed minimap after few clicks
Oh God. How didn't I see it. Will investigate.

>> - end turn is not translated and its smaller than gold income
It *is* translated, but the text was 'Turn Done' before. Will change it back.
The button uses a hard-coded 16pt font. So it's smaller than gold income only
if you use extra-big fonts in your theme. I will change it to 1.5 * (label
font size) to make sure it's always taller; I don't see why it should be
wider. (What happens when you had 10 and receive 10,000 gold?)

>> - setting max sci doesnt allow to set any gold using mouse eg. in
democracy( by left click, like previous)
Will fix.

>> - wheeling over tax was changing also endturn colour
It's disabled (thus gray) while the city managers are working. This is set by
code outside the Qt client (offending line in trunk is mapctrl_common.c:520),
and set_turn_done_button_state didn't refresh the UI as it should have done
(so the button *was* disabled, but simply not updated). Won't fix.

>> - client was always ending with Error in `client/freeciv-qt': free()
Your savegame is also crashing the client on exit without the patch (trunk).
Maybe it's related to all the cities being repaired when loading the game.
Anyway, should be reported elsewhere.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?5760>

_______________________________________________
  Message posté via/par Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to