Follow-up Comment #3, bug #23274 (project freeciv):
>> My fault, I turned them to C-style comments.
> This will obviously fix the problem, but since // comments are allowed and
natural
> in C++ code, I wondered if there was something wrong with our
string-gathering, or
> something that could be done to it, to support them.
There was no problem with // comments, but I used /// comments (as is done on
the English Wikipedia page for gettext). Just changing /// to // makes them
appear in S2_5, but not in S2_6 nor trunk. Versions 1 of the patches do this.
Investigating further, I found no TRANS: comment at all was seen by xgettext
for trunk and S2_6. The xgettext call in translations/freeciv/Makefile.in.in
has changed from this:
87 $(XGETTEXT) --default-domain=$(PACKAGE) --directory=$(top_srcdir)
88 --add-comments --keyword=_ --keyword=N_
89 --files-from=$(srcdir)/POTFILES.in
to this (patch #5401):
183 $(XGETTEXT) --default-domain=$(DOMAIN) --directory=$(top_srcdir)
184 --add-comments=TRANSLATORS: $(XGETTEXT_OPTIONS)
@XGETTEXT_EXTRA_OPTIONS@
185 --files-from=$(srcdir)/POTFILES.in
186 --copyright-holder='$(COPYRIGHT_HOLDER)'
187 --msgid-bugs-address="$$msgid_bugs_address"
Changing --add-comments=TRANSLATORS: to --add-comments=TRANS: brought back all
comments. Patch attached.
BTW, the easiest way to make sure freeciv.pot is regenerated is to run `make
freeciv.pot-update'.
(file #23841, file #23842, file #23843)
_______________________________________________________
Additional Item Attachment:
File name: bring-back-trans-comments.patch Size:1 KB
File name: qt-gettext-comments-s25-1.patch Size:5 KB
File name: qt-gettext-comments-1.patch Size:5 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23274>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
