Follow-up Comment #1, patch #5994 (project freeciv):
> - Failure to clear buffer before copying adding strings to it.
Is it really necessary to memset(0) all of the buffer in these cases? Without
checking the exact code there I would expect that it would be enough to set
"buffer[0] = '\0';" so the first catenating operation would not think there's
already something there.
> Using a pointer to an array that has gone out of scope.
Good catch. Similar construct was actively crashing sdl-clients some time ago.
Missed the fact that it was used in other places as well.
> Bad use of not operator (applies only to left-hand side of comparison,
behavior should be identical but not for the reason you would expect)
Uh, those are probably my fault of messing up when converting effects to "only
positive values count as TRUE for boolean effects" Surprisingly they seem to
be correct and not reversed (as they would be if one had just forgotten to
remove the '!')
--
Some of these seems to be touching code that is only in TRUNK and S2_6, other
parts are certainly broken in S2_5 and even S2_4 too. Will you make backport
patches? Also, are you going to make your first freeciv commit in a while, or
do you expect some of the more recently active maintainers to handle this?
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5994>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
