Follow-up Comment #4, patch #6104 (project freeciv):
"Had a quick look. I spotted some coding style issues. (See doc/CodingStyle)
Don't use tabs.
Why start the then and else blocks with an empty line?
"
1. My editor probably adds tabulators, thanks for information
2. It's because my adult - I was PHP developer for many years. I can use
C(K&R/K&D) coding style in PHP, but every PHP developer is using PHP coding
standards.
"Had a deeper look. The patch only changes unit deletion. Previous code
assumes that the unit will be wiped. Example: A player is be told that his
unit died when it (because of the patch) still may escape."
I will repair this.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6104>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
