URL:
<http://gna.org/bugs/?24074>
Summary: Limit on unit move_rate not caught during ruleset
loading
Project: Freeciv
Submitted by: jtn
Submitted on: Sat 14 Nov 2015 14:27:16 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.5.1
Discussion Lock: Any
Operating System: None
Planned Release:
_______________________________________________________
Details:
It's possible to define a unit with a move_rate which, when multiplied by
move_fragments, exceeds the network type capacity (UINT8 move_rate).
Longturn LT36 ruleset <https://github.com/longturn/games/tree/master/LT36>
(for 2.5) defines AWACS with move_rate=48, and has standard civ2civ3
move_fragments=6. This becomes 288.
Every time a client connects:
1: Trying to put 288 into 8 bits; it will result 32 at receiving side.
And AWACS appear to have "10 2/3 moves" in the client (but can in practice
move further).
Obviously we should catch this at ruleset load
On later branches we can increase the size of move_rate in the network packet;
is there any cost?
What should we do on S2_5?
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24074>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
