Update of bug #24135 (project freeciv):
Status: None => In Progress
_______________________________________________________
Follow-up Comment #9:
There's a mess in used datatypes and it seems nobody has given any thought
about the conversions between them. Sorting that like in the attached patch
for S2_5 (patches for later branches to follow later) makes this assert
failure to go away.
- Replace pathfinding specific PF_DIR_NONE use by direction8_invalid() and
direction8_is_valid()
- Make direction8_invalid() to be 8 instead of -1 to avoid signed vs unsigned
problems
- Make is_valid_dir() and is_cardinal_dir() to handle also
direction8_invalid() (that is; exact value '8', not arbitrary out-of-range
values)
(file #25984)
_______________________________________________________
Additional Item Attachment:
File name: Direction8InvalidGoto-S2_5.patch Size:11 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24135>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
