Update of patch #6104 (project freeciv):
Status: In Progress => Ready For Test
_______________________________________________________
Follow-up Comment #66:
I spent a lot of time trying to make it work so I could test it. (A typo in
setting the name of the "Hut" unit role flag prevented the default civ2civ3
ruleset from loading) Then I fixed a bug that triggered an assertion. (The
defender unit, with hp less than or equal to 0, didn't reach the "didn't
escape" code) At that point I just addressed any remaining issue I could
find.
Please improve the testing of any future patches. See
http://freeciv.wikia.com/wiki/Testing_Tips
My changes (that I remember):
* various white space changes
* various English changes
* move the documentation ruleset comments from unit class flags to unit type
flags. Remove them from rulesets that don't document unit type flags.
* rewrite and complete documentation ruleset comments
* add documentation ruleset comments to multiplayer and sandbox. (Sandbox
didn't exist when this patch was submitted)
* "?unitfLg:" -> "?unitflag:"
* fixed typo SPECENUM_VALUE74AME
* fixed type added to comment that shouldn't be changed
* move check of unit hp to escape test. (It caused a bug)
* merge if statements in escape
* assert that an escaping unit has hp left
* check that a tile has 0 units rather than that the first unit in its unit
list is NULL
* check the defense for unit type rather than unit type class
* don't tell the attacking player that he has killed a unit that escaped
* move escape text below the lost the battle text
(file #26339)
_______________________________________________________
Additional Item Attachment:
File name: Let-some-units-escape-stack-death-sveinung.patch Size:26 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6104>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
