Update of bug #24421 (project freeciv):
Status: In Progress => Ready For Test
_______________________________________________________
Follow-up Comment #3:
In this patch bug #24422 fix is included. I hope to commit all of this as one
fix, but if there's delays with this patch, bug #24422 can still go forward
separately.
I now have all four different protocol configuration combinations
simultaneously in use in different build dirs from my main source tree.
Both "delta-enabled json-disabled" and "json-enabled delta-disabled"
configurations that were known to work before still work in quick testing.
Latter still suffers from bug #24424.
In addition "delta-disabled json-disabled" configuration that I had not tested
before, seems to work. This configuration does not suffer from bug #24424.
"json-enabled delta-enabled" configuration is still broken.
When I had this almost working, I found out that I had no equivalent receive
side functionality to send side what comes to no-delta transfer of some array
types (this came up with 'global_advances' which is array of booleans) There
was just the delta-enabled version used unconditionally. I have not yet
analyzed the old code to confirm bug there, but it's likely to be broken.
While I did some trivial style corrections to the C-code generated, goal of
this patch is to get things to work, not to get them perfect. There's
certainly a lot of space for improvement in the code produced - though that's
not a hight priority as human's rarely read that code and compiler can
certainly optimize it.
(file #26751)
_______________________________________________________
Additional Item Attachment:
File name: GenericPacketsGen.patch.bz2 Size:5 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24421>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
