Update of patch #7243 (project freeciv):

             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #3:

> I think you would need to touch also some callers of the 
> get_unittype_sprite() to not use hardcoded direction (South)
Oops, missed that.

> You would also need to make the randomization case tileset 
> loading time and not within get_unittype_sprite() for keeping 
> direction consistent on those cases where it's currently 
> hardcoded for the very reason of needed consistency.
I think stable branches would benefit from that too, so I've split it to a
separate ticket: bug #24771.

(I've just noticed an outstanding problem of this kind on stable branches, but
the root cause is separate: bug #24772)

Back to this ticket, it's tempting to remove the random orientation feature
entirely, and make unit_default_orientation mandatory in tilesets with any
oriented units, and thus save the need to remember a per-unit-type
orientation. What do you think? Would any tileset actually want the random
orientation?

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?7243>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to