On 08.06.2012 11:20, Michael T. Pope wrote: > On Wed, 6 Jun 2012 11:09:19 AM Paolo Bizzarri wrote: > >> I have tried to make a Directories class, that centralize all of this >> stuff in a single place. >> >> As it is a bit invasive patch, I prefer to submit for review before >> committing it. >> > I agree the general idea is sensible. I read the patch and nothing > jumped out as broken. Except of course that the patch omits the > Directories.java file (everyone, myself included, forgets the -N diff > option:-). This made it rather hard to test. So that is your job:-). > If you have tested that no breakage happens with: > - different languages > - alternate rulesets > - mods (system and user) > - predefined maps > - save/load/autosave > - logging > - whatever I have forgotten > then I think you should go ahead and commit. > > Cheers, > Mike Pope
What he said, plus test cases would be nice. Regards Michael ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
