Re: [Freecol-developers] First Successful Merge Request completed

[winter]

When editing the code I try to reduce its size, because Java is verbose and the less code to maintain the easier it is done.

Thats why I only add to the Java-Doc comments when I think of some halfway useful text to type in manually. I'd suggest you do same.

 

Regards

 

wintertime

 

Gesendet: Montag, 30. März 2015 um 07:15 Uhr
Von: "Caleb Williams" <cale...@gmail.com>
An: "FreeCol Developers" <freecol-developers@lists.sourceforge.net>
Betreff: Re: [Freecol-developers] First Successful Merge Request completed

On Sun, Mar 29, 2015 at 10:31 PM, Caleb Williams <cale...@gmail.com> wrote:

Hey all,

 

After a long time of bashing (no pun intended) my head against the SourceForge git wall, I've managed to make a successful merge request.

 

All it should be is slight code clean up involving some of the following (client/gui/panel) files:

• Remove unneeded packages
• Add @Override tag where appropriate
• Add @param and @return were appropriate
• One or two if else to switch statements
• A couple log syntax changes --- those are what needs to be tested more of all as I'm not sure how they'll effect FreeCol.log (I'm hoping not at all)

I've compiled the changes and have received no issue so far.

 

As I mentioned, this is all semi-automated work from what NetBeans is telling me can be added. I'm not attempting any complex changes.

 

Thanks,

 

--

Caleb R. Williams

 

 

Just an FYI:

 

{@inheritDoc} existed previously. I did not add that in. I could easily run a search for all of them in Panel directory and get rid of them.

 

--

Caleb R. Williams

 

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers