On 26 October 2022 06:26:21 EEST, Bjorn Andersson <quic_bjora...@quicinc.com> wrote: >From: Bjorn Andersson <bjorn.anders...@linaro.org> > >The DisplayPort controller's internal HPD interrupt handling is used for >cases where the HPD signal is connected to a GPIO which is pinmuxed into >the DisplayPort controller. > >Most of the logic for enabling and disabling the HPD-related interrupts >is conditioned on the presence of an EDP panel, but more generically >designs that has a downstream drm_bridge (next_bridge) could use this to >handle the HPD interrupts, instead of the internal mechanism. > >So replace the current is_edp-based guards with a check for the presence >of next_bridge. This does not sound correct. The next bridge might be a dummy bridge, not supporting the hpd. Please change this to use the enable_hpd()/disable_hpd() callbacks. This way the drm_bridge_connector framework will make sure to enable hpd handling for the bridge that is actually supposed to generate hpd events. > >Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> >Signed-off-by: Bjorn Andersson <quic_bjora...@quicinc.com> >--- > >Changes since v2: >- None -- With best wishes Dmitry
- [Freedreno] [PATCH v3 08/12] drm/msm/dp: Don't enable HPD... Bjorn Andersson
- [Freedreno] [PATCH v3 06/12] drm/msm/dp: Add SDM845 Displ... Bjorn Andersson
- [Freedreno] [PATCH v3 11/12] arm64: dts: qcom: sc8280xp-c... Bjorn Andersson
- [Freedreno] [PATCH v3 02/12] drm/msm/dpu: Introduce SC828... Bjorn Andersson
- Re: [Freedreno] [PATCH v3 02/12] drm/msm/dpu: Introd... Dmitry Baryshkov
- [Freedreno] [PATCH v3 07/12] drm/msm/dp: Implement hpd_no... Bjorn Andersson
- [Freedreno] [PATCH v3 05/12] drm/msm/dp: Add DP and EDP c... Bjorn Andersson
- [Freedreno] [PATCH v3 04/12] drm/msm/dp: Stop using DP id... Bjorn Andersson
- Re: [Freedreno] [PATCH v3 04/12] drm/msm/dp: Stop us... Dmitry Baryshkov
- [Freedreno] [PATCH v3 09/12] drm/msm/dp: HPD handling rel... Bjorn Andersson
- Re: [Freedreno] [PATCH v3 09/12] drm/msm/dp: HPD han... Dmitry Baryshkov
- Re: [Freedreno] [PATCH v3 09/12] drm/msm/dp: HPD... Bjorn Andersson
- [Freedreno] [PATCH v3 12/12] arm64: dts: qcom: sa8295-adp... Bjorn Andersson
- Re: [Freedreno] [PATCH v3 12/12] arm64: dts: qcom: s... Johan Hovold
- Re: [Freedreno] [PATCH v3 12/12] arm64: dts: qco... Bjorn Andersson
- [Freedreno] [PATCH v3 10/12] arm64: dts: qcom: sc8280xp: ... Bjorn Andersson
- Re: [Freedreno] [PATCH v3 10/12] arm64: dts: qcom: s... Johan Hovold
- Re: [Freedreno] [PATCH v3 10/12] arm64: dts: qcom: s... Kuogee Hsieh
- Re: [Freedreno] [PATCH v3 10/12] arm64: dts: qco... Bjorn Andersson