On Fri, 5 Apr 2024 at 03:01, Stephen Boyd <[email protected]> wrote: > > The register base that was used to write to the QSERDES_DP_PHY_MODE > register was 'dp_dp_phy' before commit 815891eee668 ("phy: > qcom-qmp-combo: Introduce orientation variable"). There isn't any > explanation in the commit why this is changed, so I suspect it was an > oversight or happened while being extracted from some other series. > Oddly the value being 0x4c or 0x5c doesn't seem to matter for me, so I > suspect this is dead code, but that can be fixed in another patch. It's > not good to write to the wrong register space, and maybe some other > version of this phy relies on this. > > Cc: Douglas Anderson <[email protected]> > Cc: Abhinav Kumar <[email protected]> > Cc: Dmitry Baryshkov <[email protected]> > Cc: Neil Armstrong <[email protected]> > Cc: Abel Vesa <[email protected]> > Cc: Steev Klimaszewski <[email protected]> > Cc: Johan Hovold <[email protected]> > Cc: Bjorn Andersson <[email protected]> > Fixes: 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable") > Signed-off-by: Stephen Boyd <[email protected]> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <[email protected]> -- With best wishes Dmitry
