On 4/17/2025 4:10 PM, Dmitry Baryshkov wrote:
> On Thu, Apr 17, 2025 at 11:09:05AM +0530, Ayushi Makhija wrote:
>> From: Ayushi Makhija <quic_amakh...@quicinc.com>
>>
>> Add anx7625 DSI to DP bridge device nodes.
>>
>> Signed-off-by: Ayushi Makhija <quic_amakh...@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 180 +++++++++++++++++++++
>> 1 file changed, 180 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> index 175f8b1e3b2d..d5b2dabe927d 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> @@ -28,6 +28,13 @@ chosen {
>> stdout-path = "serial0:115200n8";
>> };
>>
>> + vph_pwr: vph-pwr-regulator {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vph_pwr";
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> vreg_conn_1p8: vreg_conn_1p8 {
>> compatible = "regulator-fixed";
>> regulator-name = "vreg_conn_1p8";
>> @@ -128,6 +135,30 @@ dp1_connector_in: endpoint {
>> };
>> };
>> };
>> +
>> + dp-dsi0-connector {
>> + compatible = "dp-connector";
>> + label = "DSI0";
>> + type = "full-size";
>> +
>> + port {
>> + dp_dsi0_connector_in: endpoint {
>> + remote-endpoint = <&dsi2dp_bridge0_out>;
>> + };
>> + };
>> + };
>> +
>> + dp-dsi1-connector {
>> + compatible = "dp-connector";
>> + label = "DSI1";
>> + type = "full-size";
>> +
>> + port {
>> + dp_dsi1_connector_in: endpoint {
>> + remote-endpoint = <&dsi2dp_bridge1_out>;
>> + };
>> + };
>> + };
>> };
>>
>> &apps_rsc {
>> @@ -519,7 +550,107 @@ &i2c18 {
>> clock-frequency = <400000>;
>> pinctrl-0 = <&qup_i2c18_default>;
>> pinctrl-names = "default";
>> +
>> status = "okay";
>> +
>> + io_expander: gpio@74 {
>> + compatible = "ti,tca9539";
>> + reg = <0x74>;
>> + interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>
> No reset-gpios? Is the expander being used by something else so that we
> don't want it to be reset during the bootup?
>
Hi Dmitry,
Reset-gpios is optional for tca9539, because of which it is not throwing an
error.
After adding reset-gpios = <&tlmm 97 GPIO_ACTIVE_LOW>; it is working. Will add
it in next
patchset.
Thanks,
Ayushi
>> +
>> + pinctrl-0 = <&io_expander_intr_active>,
>> + <&io_expander_reset_active>;
>> + pinctrl-names = "default";
>> + };
>> +
>
> The rest LGTM
>
