On Tue, Apr 22, 2025 at 12:28:20PM +0530, Ayushi Makhija wrote:
> On 4/17/2025 4:10 PM, Dmitry Baryshkov wrote:
> > On Thu, Apr 17, 2025 at 11:09:05AM +0530, Ayushi Makhija wrote:
> >> From: Ayushi Makhija <quic_amakh...@quicinc.com>
> >>
> >> Add anx7625 DSI to DP bridge device nodes.
> >>
> >> Signed-off-by: Ayushi Makhija <quic_amakh...@quicinc.com>
> >> ---
> >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 180 +++++++++++++++++++++
> >> 1 file changed, 180 insertions(+)
> >>
> >> @@ -519,7 +550,107 @@ &i2c18 {
> >> clock-frequency = <400000>;
> >> pinctrl-0 = <&qup_i2c18_default>;
> >> pinctrl-names = "default";
> >> +
> >> status = "okay";
> >> +
> >> + io_expander: gpio@74 {
> >> + compatible = "ti,tca9539";
> >> + reg = <0x74>;
> >> + interrupts-extended = <&tlmm 98 IRQ_TYPE_EDGE_BOTH>;
> >> + gpio-controller;
> >> + #gpio-cells = <2>;
> >> + interrupt-controller;
> >> + #interrupt-cells = <2>;
> >
> > No reset-gpios? Is the expander being used by something else so that we
> > don't want it to be reset during the bootup?
> >
> Hi Dmitry,
>
> Please, ignore the previous reply.
>
> This io_expander is used by anx7625 bridge only. I have defined the gpio in
> pinctrl setting and so far it was helping out indirectly to bring io_expander
> out
> of the reset. The reset-gpios is optional for tca9539, because of which the
> io_expander driver didn't throw an error and I never realize that I should
> add this property.
>
> I tested by adding the reset-gpios entry and it's working fine. I will update
> in the next patchset.
>
> + reset-gpios = <&tlmm 97 GPIO_ACTIVE_LOW>;
>
> Thanks again, for pointing it out.
SGTM
>
> Thanks,
> Ayushi
>
> >> +
> >> + pinctrl-0 = <&io_expander_intr_active>,
> >> + <&io_expander_reset_active>;
> >> + pinctrl-names = "default";
> >> + };
> >> +
> >
> > The rest LGTM
> >
>
--
With best wishes
Dmitry
