On 5/12/26 12:23 AM, Akhil P Oommen wrote: > From: Qingqing Zhou <[email protected]> > > Add the Adreno GPU SMMU node for kaanapali platform. > > Signed-off-by: Qingqing Zhou <[email protected]> > Signed-off-by: Akhil P Oommen <[email protected]> > --- > arch/arm64/boot/dts/qcom/kaanapali.dtsi | 41 > +++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi > b/arch/arm64/boot/dts/qcom/kaanapali.dtsi > index bab654bbd6d0..26a4de9c8d45 100644 > --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi > +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi > @@ -2597,6 +2597,47 @@ gpucc: clock-controller@3d90000 { > #power-domain-cells = <1>; > }; > > + adreno_smmu: iommu@3da0000 { > + compatible = "qcom,kaanapali-smmu-500", > "qcom,adreno-smmu", > + "qcom,smmu-500", "arm,mmu-500";
The lines are misaligned, but please reshuffle this to be 1 a line > + reg = <0x0 0x3da0000 0x0 0x40000>; Please keep the 8-hex-digit padding for addr > + #iommu-cells = <2>; > + #global-interrupts = <1>; > + dma-coherent; > + > + power-domains = <&gpucc GPU_CC_CX_GDSC>; > + > + clocks = <&gpucc GPU_CC_GPU_SMMU_VOTE_CLK>; > + clock-names = "hlos"; > + > + interrupts = <GIC_SPI 674 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 678 IRQ_TYPE_LEVEL_HIGH>, likewise, please align the '<'s and align the property order in this node with Glymur Konrad
