The 1.2 LDAP module was throwing a deprecation warning for using popen2 and pychecker found a slew of other issues as well.

This patch removes a bunch of unused imports, renames some variables that shadowed builtins and renames some functions.


exportLDIF() calls a function that isn't provided. This must have gotten left over from when I ported this from Rich's original LDAP module which did all sorts of stuff. I think we can drop this as it doesn't even work but wanted to throw it out there on the off-chance that someone found a way to use it.

rob

Attachment: freeipa-243-cleanup.patch
Description: application/mbox

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to