On 11/1/2010 12:58 PM, Adam Young wrote:
For the 'add and add again' useage.
NACK. The following for-loop shouldn't be moved into add_win() because it breaks the service add dialog.
- for (var i = 0; i < that.fields.length; ++i) { - var field = that.fields[i]; - if (field.setup) { - var value = field.setup(dialog, IPA_ADD_UPDATE); - if (value != null) { - if (field.name == pkey_name) - pkey = [value]; - else + for (var i = 0; i < that.fields.length; ++i) { + var field = that.fields[i]; + if (field.setup) { + var value = field.setup(dialog, IPA_ADD_UPDATE); + if (value != null) { + if (field.name == pkey_name) + pkey = [value]; + } else { options[field.name] = value; + } } } -- Endi S. Dewata _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel