On Mon, 22 Nov 2010 13:58:40 +0100 Jakub Hrozek <[email protected]> wrote:
> On Mon, Nov 15, 2010 at 09:05:55PM -0500, Simo Sorce wrote: > > > > Add code to detect the number of CPUs available at install time. > > If the kerberos version is >= 1.9 then the KDC supports multiple > > workers. > > If more than 1 CPU is available configure the KDC to start 1 worker > > per CPU to aid in scalability. > > > > Addresses ticket #222 > > > > Simo. > > As I don't have Kerberos 1.9 (does not seem to be even in F15..) I > only tested that the patch modifies the /etc/sysconfig/krb5kdc file. > > The code looks good and seems to work fine. I have two suggestions: > > 1) we should test if the open() calls succeed In what case it can fail ? > 2) I think that we should log that we are about to modify a file We don't do that for any of the many files we modify, why should we ? > A more general thought (although it's certainly not a task for 2.0), > maybe we should consider using Augeas, either via its Python API or > just calling augtool to modify config files. The benefits would be > safer modifications (augeas knows the file structure) and most > probably even cleaner code. This is a good idea, can you open an enhancement ticket ? Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
