-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/22/2010 03:12 PM, Jakub Hrozek wrote: >> In what case it can fail ? > For instance if the file was not present, if its SELinux label was > wrong..I just think it's good defensive behaviour. > > Although it is true that the scripts would catch the exception and print > a more meaingful error message than just an ugly traceback, which was > basically my point. So this might actually be fine. > >> > >>> >> 2) I think that we should log that we are about to modify a file >> > >> > We don't do that for any of the many files we modify, why should we ? > OK, If we don't do that already, it makes no sense to do it for this > single occurrence. FWIW, I was thinking that as an admin I would > probably like to see when config on my system changes - at least when > the log level is set to debug. >
This could have been shortened to Ack :-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkzqhpMACgkQHsardTLnvCW7tgCgjmCvQZaLduhy77QU6BV8MmZU BQoAoIwxdJDEtDHwjmJ0vgPfo6OcIanw =n1X0 -----END PGP SIGNATURE----- _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel