On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: > https://fedorahosted.org/freeipa/ticket/1283 > https://fedorahosted.org/freeipa/ticket/1284 > > Honza
Patch works fine, but I'd like to improve code quality a bit. Please don't call sys.exit() from get_dirman_password(). It doesn't make really sense. I suggest just returning None in that case and then exiting in the main function. Or raising a proper exception and then exiting in the main function. The get_dirman_password() function can then be later reused easily. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
