On Mon, 2011-06-13 at 12:32 +0200, Jan Cholasta wrote: > On 9.6.2011 14:50, Martin Kosek wrote: > > On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: > >> https://fedorahosted.org/freeipa/ticket/1283 > >> https://fedorahosted.org/freeipa/ticket/1284 > >> > >> Honza > > > > Patch works fine, but I'd like to improve code quality a bit. Please > > don't call sys.exit() from get_dirman_password(). It doesn't make really > > sense. > > > > I suggest just returning None in that case and then exiting in the main > > function. Or raising a proper exception and then exiting in the main > > function. The get_dirman_password() function can then be later reused > > easily. > > Good point. Fixed.
ACK. Pushed to master, ipa-2-0. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
