On Wed, 2011-07-20 at 19:59 -0400, John Dennis wrote: > The pairwise grouping used to form RDN's and AVA's proved to be > confusing in practice, this patch removes that functionality thus > requiring programmers to explicitly pair attr,value using a tuple or > list. > > In addition it was discovered additional functionality was needed to > support some DN operations in freeipa. DN objects now support > startswith(), endswith() and the "in" membership test. These functions > and operators will accept either a DN or RDN. > > The unittest was modified to remove the pairwise tests and add new > explicit tests. The unittest was augmented to test the new > functionality. In addition the unittest was cleaned up a bit to use > common utilty functions for improved readabilty and robustness. > > The documentation was updated. >
The patch looks good to me. The removed form of creating DN's was indeed confusing. I went through current uses of DN class, I didn't find any using the removed form. DN tests also passes correctly. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel