On 8/5/2011 11:33 AM, Petr Vobornik wrote:
The default values in ipa.js:576-579 are redundant because they will be
overridden by the spec in init().

I think the assignments in init() can
be replaced by something like this:
      that.xhr = spec.xhr || {};
Note that the default value for xhr and error_thrown should be an empty
Reworked, probably we should add some generic error title to internal.py
as default value for error dialog title.

There are some unit test failures in ipa_tests.js because
IPA.error_dialog used to point to the dialog instance. You might want to
change it to get the instance using something else, e.g. element ID.

- Added property 'id' to dialog (which is added to its div)
- Added reference to ../dialog.js in ipa.tests.html
- Reworked ipa.test.js to work with error_dialog id.

There are some other other unit test failures, but they seem to be
caused by the earlier failure. They actually pass if run separately.
-->  All test should pass.

ACK and pushed to master.

Endi S. Dewata

Freeipa-devel mailing list

Reply via email to