On 08/08/2011 09:50 AM, Petr Vobornik wrote:
On 08/05/2011 11:12 PM, Adam Young wrote:
On 08/05/2011 09:22 AM, Petr Vobornik wrote:
Redirection after changing browser configuration
https://fedorahosted.org/freeipa/ticket/1502
Added redirection link.
Notes:
Modified preferences.html.template to be able to respond to the
configuration change.
Because of security politics page cannot be automatically redirected.
(has to redirect top frame). -> Message with link was added.
Redirection link has to use absolute url because page is situated in
object frame and its location points to jar archive.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Looks good. The formatting of the Link at the end is wrapped around
across multiple lines. Of course, right now, we are missing the css
there, so maybe it is due to the stylesheet error.
If you can put the message on one line and the link on the second, I'd
consider it ACKed
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
The link alone can't fit on a single line.
- I have expanded the object's area. (and cleaned css from trailing
white spaces in the process)
- Added css in preferences template in order to look good. In the
future it would be better to remove these css and reuse ipa_error.css.
But it has to be included in the jar (I don't know where to do it).
- Corrected object tag ending so "Back to the Web UI" link is
displayed even if user has not configured Firefox (this can be useful
for other browser's users or if user don't want to configure browser.
But it is redundant with the link which is displayed after
configuration.).
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
OK, ACKed and pushed to master.
edewata is working on a fix for the CSS for the error/config pages.
Please make sure to integrate that fix with tuning the layout issues for
this one.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
