On 08/23/2011 11:09 PM, Endi Sukma Dewata wrote:
On 8/23/2011 6:34 AM, Petr Vobornik wrote:
Please take a look at the attached patch. This should be applied on top
of your patch. It does several things:
1. As mentioned over IRC, we should be treating these partial failure as
a success (the command does return a success). This way it's not going
to show the Retry button.
2. Instead of concatenating the messages, they are now added into the
error list. This way they will appear nicely as a list.
3. If the error dialog appears, it will wait until you click OK before
continuing.
4. Since some of the membership operations are done using serial
associator you might get multiple dialogs, but this should be gone once
we fix #1688.
Please feel free to merge this patch into yours if you want to make
further modifications. Or we can push both patches if you think it's
good enough.
It's good enough for #1628 so we can push both patches.
I can think of some more improvements, but it can be done separately.
I'm not sure if we need to show the completed operations because we
should be able to infer that from the command we're trying to execute
and the error message we're getting. No error means it's completed.
Maybe we should try to provide a better error message, e.g. "Some
failures occurred when removing users from group editors".
This isn't probably important. If user is removing some users from group
he should know that message "Some parts of operation failed" is related
to his action.
Also, we
might want to change the 'Operations Error' title because it's actually
a success. How about 'Operation Completed'? This can be done separately.
Agree
If you think showing the completed operations would be useful please
file a ticket and we'll discuss it. We might be able to show the
completed operations under 'Show details'.
It can be useful, but I think it isn't high priority. I filed
enhancement ticket https://fedorahosted.org/freeipa/ticket/1702 .
Other problem in error dialog is that there are used untranslated
strings. We should modify it to use translated and as fallback (like in
init method) untranslated.
Let's put the locations of any untranslated messages we find into this
ticket: https://fedorahosted.org/freeipa/ticket/1701
--
Petr Vobornik
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
