On 26.08.2011 18:59, Sumit Bose wrote:
>>> +def parse_options():
>>> + parser = IPAOptionParser(version=version.VERSION)
>>> + parser.add_option("-p", "--ds-password", dest="dm_password",
>>> + sensitive=True, help="admin password")
>> If this is the only password you need, then make it --password. And it
>> is Directory Manager's account password, right? Would be nice to change
>> help to be more explicit.
>
> ipa-server-install and ipa-dns-install use the same option for the same
> purpose, so I thought it might be a good idea to use the same. But you
> are right "admin password" is misleading here. Maybe the help should be
> fixed in ipa-server-install and ipa-dns-install, too?
Please file a ticket for that.
>>> diff --git a/ipaserver/install/smbinstance.py
>>> b/ipaserver/install/smbinstance.py
>>> new file mode 100644
>> The code in smbinstance.py assumes Samba has been compiled with
>> /etc/ipa/smb.conf as default configuration file location. Is that correct?
>>
>
> no, __write_sysconfig_samba() adds "-s /etc/ipa/smb.conf" to
> SMBDOPTIONS in /etc/sysconfig/samba.
But then net utility will not be able to use it. Same for nmbd and
winbindd. If for last two you could use /etc/sysconfig/samba to direct
them to a proper configuration, you can't do so for /usr/bin/net.
--
/ Alexander Bokovoy
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
