On Tue, 2011-08-30 at 16:40 +0200, Sumit Bose wrote:
> I don't think that we should run winbind.
> I also changed the path to the smb.conf file from /etc/ipa
> to /etc/samba
> which makes the change to /etc/sysconfig/samba unnecessary.
> Thanks for review.
Ok tested this today, after I was able to tame my machine.

Some issues and comments still.

1) If you just run ipa-adtrust-install it throws an error about an
Illegal netbios name and quits. That's not right, as it should ask for
the netbios name if one is not provided on the command line presenting a
default option (based on the last domain component uppercased maybe),

2) I see the way you write the temp smb.conf is by using a lot of
fd.write() calls. It would be much easier instead to use the templating
engine we use elsewhere in the code and drop a template file in
install/share, this will allow us to easily tweak the initial
installation options w/o touching the python code every time.

3) Everything installed and started but my smbd coredump immediately
after. It is almost certainly not a problem in your patch though :-)

So jokes aside if you fix 1 and 2 I think we can push to master.


Simo Sorce * Red Hat, Inc * New York

Freeipa-devel mailing list

Reply via email to