Hello, The .isalpha() check in validate_domain_name() was too strict, causing some commands like ipa dnsrecord-add to fail.
https://fedorahosted.org/freeipa/ticket/3385 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc.
From 853ea94cebcc062773543a70479172283b4e7f42 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic <akriv...@redhat.com> Date: Fri, 15 Feb 2013 08:47:06 -0500 Subject: [PATCH] Remove check for alphabetic only characters from domain name validation The .isalpha() check in validate_domain_name() was too strict, causing some commands like ipa dnsrecord-add to fail. https://fedorahosted.org/freeipa/ticket/3385 --- ipalib/util.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/ipalib/util.py b/ipalib/util.py index a92e68c4af8092852400d59ff1af8c73cbca3f92..c0519cf956faf749cc0134cc0aa29ee375015a3a 100644 --- a/ipalib/util.py +++ b/ipalib/util.py @@ -223,9 +223,6 @@ def validate_domain_name(domain_name, allow_underscore=False): # apply DNS name validator to every name part map(lambda label:validate_dns_label(label,allow_underscore), domain_name) - if not domain_name[-1].isalpha(): - # see RFC 1123 - raise ValueError(_('top level domain label must be alphabetic')) def validate_zonemgr(zonemgr): """ See RFC 1033, 1035 """ -- 1.8.0
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
