On 07/29/2013 03:10 PM, Petr Vobornik wrote:
> On 07/29/2013 02:21 PM, Ana Krivokapic wrote:
>> On 07/29/2013 11:45 AM, Petr Vobornik wrote:
>>> dialog.textarea = $('<textarea/>', {
>>> 'class': 'certificate',
>>> - readonly: that.read_only,
>>> + readonly: !writable,
>>> disabled: !that.enabled
>>> }).appendTo(dialog.container);
>>
>> I suggest setting the 'disabled' attribute on the text area in case it's not
>> writable:
>>
>> disabled: !that.enabled || !writable
>>
>> That way, when the user opens the dialog, the textarea is greyed out and it
>> is
>> immediately clear that it is not editable.
>>
>
> I agree that we should distinguish the look of readonly textarea, but
> 'disabled' attribute is not the right one for the task. Disabled inputs
> have(at least in FF) behavior which we don't want for readonly:
> * they are not fucusable
> * user can't select(copy) text
>
> I've added new css style to create the distinction.
>
> Updated patch attached.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> [email protected]
> https://www.redhat.com/mailman/listinfo/freeipa-devel
Looks good, ACK.
While I was testing this patch, I noticed that syncing CSS files using the
install/ui/util/sync.sh script is broken. Attached is a two-liner fix.
--
Regards,
Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.
From 72094c5b3907e2d614667a2ddf1614104d5d024f Mon Sep 17 00:00:00 2001
From: Ana Krivokapic <[email protected]>
Date: Mon, 29 Jul 2013 15:43:18 +0200
Subject: [PATCH] Fix handling of CSS files in sync.sh script
---
install/ui/util/sync.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/install/ui/util/sync.sh b/install/ui/util/sync.sh
index f43280273303ea8b7fbb9ce028fd054834eb2143..423dc0c5bddf60b350049b30436b2264d241ba0e 100755
--- a/install/ui/util/sync.sh
+++ b/install/ui/util/sync.sh
@@ -296,8 +296,8 @@ pushd $DIR/../../ #freeipa/install
fi
if [[ $CSS ]] ; then
- SOURCE=ui/css/*
- TARGET=$TARGET_BASE/ui/css
+ SOURCE=ui/*.css
+ TARGET=$TARGET_BASE/ui
RECURSIVE=1
EXCEPTIONS="--exclude /Makefile*"
sync-files
--
1.8.1.4
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
