-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/30/2013 09:21 AM, Lukas Slebodnik wrote: > ehlo, > > There were few warnings in bind-dyndb-ldap "duplicate 'const' declaration > specifier". > > It does not make sense to have const twice in declaration > like a "const settings_set_t const settings_default_set" > This one was false positive. > > The 2nd warning revealed potential problem. > const char const * dns_str > With previous declaration, you cannot modify data, but you can modify > pointer itself. > *dns_str = "asdasd" //compilation error > dns_str++ //works fine > > If you want to disable modification data and disable modification of pointer > you will need to have 2nd const modifier after star "*" > > You can find some examples of "const" usage in attached file test.c or > you can read article with explanation of next declaration > "char *(*(**foo [][8])())[];" > http://eli.thegreenplace.net/2008/07/18/reading-c-type-declarations/ > > Simple patch is attached. > > LS >
ACK. Looks good. Regards, Tomas Hozza -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJS2UbdAAoJEMWIetUdnzwtqKIIAKEnhrYiT85yvGYkMVUjGZ5Y s42WXAcJOswo8rAiZwbMPmyGU7Imr+tEYf92Uu8S9kRipI6RnQYO0WFjt/HP/qQJ DblisCEgrWiPwYRTrEVuk2K7HZXUIvcEhB6KXgGPLsBw0bNFxb8FYs2GND4NjByU c/OCTGLaRsRxqX7sLn4UYZl32xic/QKJUeUWkfSgCbB7hzAOQJh65I5pW8e8LJre DBihpudiWVs2c13rIxyAyvbGcJ9X3HUuiRt/j2kWIhK4ESzB7Rf2cE3R1Frz7Do9 uDz8/q9WXIXmmQKCnK3zc8IM1LukPBYQUFN2j9ThiqzDFb/lMhGpXO3EeNRtiMM= =t8pR -----END PGP SIGNATURE----- _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
