On 17.1.2014 16:06, Tomas Hozza wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/30/2013 09:21 AM, Lukas Slebodnik wrote:
ehlo,

There were few warnings in bind-dyndb-ldap "duplicate 'const' declaration
specifier".

It does not make sense to have const twice in declaration
like a "const settings_set_t const settings_default_set"
This one was false positive.

The 2nd warning revealed potential problem.
const char const * dns_str
With previous declaration, you cannot modify data, but you can modify
pointer itself.
*dns_str = "asdasd" //compilation error
dns_str++           //works fine

If you want to disable modification data and disable modification of pointer
you will need to have 2nd const modifier after star "*"

You can find some examples of "const" usage in attached file test.c or
you can read article with explanation of next declaration
"char *(*(**foo [][8])())[];"
http://eli.thegreenplace.net/2008/07/18/reading-c-type-declarations/

Simple patch is attached.

LS


ACK.

Looks good.

Pushed to v3 and master branch: b39142b9d75ac296662b42d7efd98475d2bd7608

--
Petr^2 Spacek

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to