On 02/05/2014 10:29 AM, Tomas Babej wrote:
Hello,

the attached patches fix the following tickets:

https://fedorahosted.org/freeipa/ticket/4131
https://fedorahosted.org/freeipa/ticket/4130
https://fedorahosted.org/freeipa/ticket/4133

Details in the commit messages.

Tomas


These look good, just a few nitpicks:

Use a lowercase "A" in option and method names in 0144 to keep consistent with our naming convention.

Add an article to the add_a_record docstring & man page:
Adds an A record for the host to the IPA master

and the help text for the host argument could be better:
Host whose record should be added
(or, Host for which the record should be added)

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to