----- Original Message -----
> From: "Jan Cholasta" <jchol...@redhat.com>
> To: "Adam Misnyovszki" <amisn...@redhat.com>, freeipa-devel@redhat.com
> Sent: Friday, February 21, 2014 11:05:12 AM
> Subject: Re: [Freeipa-devel] [PATCH] Certificate search max_serial_number 
> problem fixed
> 
> Hi,
> 
> On 20.2.2014 18:15, Adam Misnyovszki wrote:
> > Hi,
> >
> > this patch fixes ticket https://fedorahosted.org/freeipa/ticket/4163
> > maximum serial number field now accepts only positive numbers
> >
> > Thanks
> > Adam
> 
> I think you should also add maxvalue to min_serial_number, so that they
> are consistent.
> 
> Honza
> 
> --
> Jan Cholasta
> 

Makes sense, new patch added.

Adam
From 831fd9810eb5daef9081267f3c2a6d37884c3795 Mon Sep 17 00:00:00 2001
From: Adam Misnyovszki <amisn...@redhat.com>
Date: Fri, 21 Feb 2014 12:08:55 +0100
Subject: [PATCH] Certificate search max_serial_number problem fixed

Maximum serial number field now accepts only positive numbers

https://fedorahosted.org/freeipa/ticket/4163
---
 ipalib/plugins/cert.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ipalib/plugins/cert.py b/ipalib/plugins/cert.py
index 762f13b0f07cb725efb97b15ab4a633d7dec22a8..5fa9206d5146234b0f6222bf156875828652ebb6 100644
--- a/ipalib/plugins/cert.py
+++ b/ipalib/plugins/cert.py
@@ -650,10 +650,12 @@ class cert_find(Command):
             doc=_("minimum serial number"),
             autofill=False,
             minvalue=0,
+            maxvalue=2147483647,
         ),
         Int('max_serial_number?',
             doc=_("maximum serial number"),
             autofill=False,
+            minvalue=0,
             maxvalue=2147483647,
         ),
         Flag('exactly?',
-- 
1.8.5.3

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to