On 06/10/2014 10:13 AM, Tomas Babej wrote: > Thank you for the detailed review. Responses to all the issues found are > inline: > > On 06/06/2014 01:04 PM, Petr Viktorin wrote: ... >>> 0209: >>> ipa-client-install, --noac help: "Red Hat" has two words. Also it's a >>> company; I don't think "Red Hat based distributions" is a correct use of >>> the trademark. In comments/class names it doesn't really matter but in >>> user-facing text we should try to be professional. >>> We can either go with "Fedora-based" here and sort this out in a RHEL >>> patch if needed, or better, adjust the help text (or visibility of the >>> option) based on if the platform uses authconfig. >>> > I'm thinking we could go as far as to provide a way in the installers to > define > platform dependent options. What do you think?
I think it may be needed one day (in a galaxy far far away) when there is sufficient need for it. But I do not think that this use case warrants it. As Petr suggested, I would go just with the original help or something like that: help="do not modify the nsswitch.conf and PAM configuration (does not run authconfig, when available)" Martin _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
