On 06/16/2014 02:53 PM, Tomas Babej wrote:
On 06/10/2014 05:07 PM, Petr Viktorin wrote:
On 06/10/2014 10:13 AM, Tomas Babej wrote:
On 06/06/2014 01:04 PM, Petr Viktorin wrote:
On 06/05/2014 03:14 PM, Petr Viktorin wrote:
On 06/04/2014 11:42 AM, Tomas Babej wrote:
Hi,
the following set of patches implements the ticket:
https://fedorahosted.org/freeipa/ticket/4052
[...]
0202: OK
0203: OK
0204: OK
0205: OK
0206: OK
0207: OK
(sorry for the conflict!)
0208: OK
0209: OK
0210: OK
0211: OK
0212: OK
0213: OK
0214: OK
0215: OK
0216: OK
0217: OK
0218: OK
0219: OK
0220: OK
0221: OK
0222: OK
modify_nsswitch_pam_stack and modify_pam_to_use_krb5 are missing the
`self` argument.
Rebasing this all the time must be painful, so to avoid another review
round-trip I've had Tomáš ACK the attached four-liner on IRC.
0223: OK
ACK to the above with my fix, but see more comments below.
Pushed to master: d868fc5566da547d2060ef4a42eb5a0d0e0a72d6
0224:
insert_ca_cert_into_systemwide_ca_store
remove_ca_cert_from_systemwide_ca_store
typo: certificated
restore_pre_ipa_client_configuration
mentions obsolete tasks
Additional:
Is tasks.get_svc_list_file necessary?
--
Petr³
From 9e2627b3c407ad222c70a3b2cf935ba8d769140e Mon Sep 17 00:00:00 2001
From: Petr Viktorin <[email protected]>
Date: Mon, 16 Jun 2014 18:49:47 +0200
Subject: [PATCH] Fix self argument in tasks
---
ipaplatform/base/tasks.py | 4 ++--
ipaplatform/fedora/tasks.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ipaplatform/base/tasks.py b/ipaplatform/base/tasks.py
index f4bfbb6dbababfa2a764c1dcaa6770b9a70c1a39..b8ebbdfacfd7be0e9c1d334100b77e0b857b2491 100644
--- a/ipaplatform/base/tasks.py
+++ b/ipaplatform/base/tasks.py
@@ -60,10 +60,10 @@ def restore_pre_ipa_client_configuration(self, fstore, statestore,
def set_nisdomain(self, nisdomain):
return
- def modify_nsswitch_pam_stack(sssd, mkhomedir, statestore):
+ def modify_nsswitch_pam_stack(self, sssd, mkhomedir, statestore):
return
- def modify_pam_to_use_krb5(statestore):
+ def modify_pam_to_use_krb5(self, statestore):
return
task_namespace = BaseTaskNamespace()
diff --git a/ipaplatform/fedora/tasks.py b/ipaplatform/fedora/tasks.py
index a3a5073647ae8d6ca962c0a2221c66ce900e17bb..c20ecd30142281377f49eb56f92530414d2960a7 100644
--- a/ipaplatform/fedora/tasks.py
+++ b/ipaplatform/fedora/tasks.py
@@ -122,7 +122,7 @@ def set_nisdomain(self, nisdomain):
auth_config.add_parameter("nisdomain", nisdomain)
auth_config.execute()
- def modify_nsswitch_pam_stack(sssd, mkhomedir, statestore):
+ def modify_nsswitch_pam_stack(self, sssd, mkhomedir, statestore):
auth_config = FedoraAuthConfig()
if sssd:
@@ -141,7 +141,7 @@ def modify_nsswitch_pam_stack(sssd, mkhomedir, statestore):
auth_config.execute()
- def modify_pam_to_use_krb5(statestore):
+ def modify_pam_to_use_krb5(self, statestore):
auth_config = FedoraAuthConfig()
statestore.backup_state('authconfig', 'krb5', True)
auth_config.enable("krb5")
--
1.9.0
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
