On 06/19/2014 12:52 PM, Tomas Babej wrote: > On 06/18/2014 10:52 AM, Petr Viktorin wrote: >> On 06/17/2014 02:15 PM, Tomas Babej wrote: >>> On 06/17/2014 12:03 PM, Timo Aaltonen wrote: >>>> On 17.06.2014 11:16, Martin Kosek wrote: >>> Attached is a new version of patch 226, and a new patch 228, which moves >>> the paths from installers to the paths module. >> In patch 226, there's another "certificated" typo in >> remove_ca_cert_from_systemwide_ca_store >> >>> I greped the repository, and I do not see many paths lurking around any >>> more, there are only some in the error messages (as these can't be >>> reliably replaced automatically, and will need some manual love). >>> >>> If you see any forgotten paths, which should be added to the module, let >>> me know. >> >> I see another duplicate: >> SSS_KRB5_INCLUDE_D = "/var/lib/sss/pubconf/krb5.include.d" >> SSSD_PUBCONF_KRB5_INCLUDE_D_DIR = >> "/var/lib/sss/pubconf/krb5.include.d/" >> >> >> Rather than using e.g. >> filename = paths.VAR_KERBEROS_KRB5KDC_DIR + file >> It would be cleaner to use >> filename = os.path.join(paths.VAR_KERBEROS_KRB5KDC_DIR, file) >> >> > Fixed all mentioned issues. I also attached a patch 230, which removes > the base Authconfig class. > Attaching one additional patch, which removes unnecessary build warnings.
-- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org
>From 687e44b6ab9eab2bd0349c3ddbe7457c20f40bf1 Mon Sep 17 00:00:00 2001 From: Tomas Babej <tba...@redhat.com> Date: Thu, 19 Jun 2014 15:09:37 +0200 Subject: [PATCH] ipaplatform: Fix build warnings The newly created ipaplatform subdirectories base and fedora were mentioned multiple times in the specfile, which produced build warnings. Part of: https://fedorahosted.org/freeipa/ticket/4052 --- freeipa.spec.in | 4 ---- 1 file changed, 4 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index b719b4a21fd2263a6fb58b3dffd4784868e630e9..823c34354e4a42ae548f0d969bbf67d6c2471a9b 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -832,11 +832,7 @@ fi %dir %{python_sitelib}/ipalib %{python_sitelib}/ipalib/* %dir %{python_sitelib}/ipaplatform -%dir %{python_sitelib}/ipaplatform/base -%dir %{python_sitelib}/ipaplatform/fedora %{python_sitelib}/ipaplatform/* -%{python_sitelib}/ipaplatform/base/*.py* -%{python_sitelib}/ipaplatform/fedora/*.py* %attr(0644,root,root) %{python_sitearch}/default_encoding_utf8.so %{python_sitelib}/ipapython-*.egg-info %{python_sitelib}/freeipa-*.egg-info -- 1.9.3
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
