On 25/09/14 09:59, Martin Kosek wrote:
On 09/24/2014 06:22 PM, Martin Basti wrote:
On 24/09/14 17:30, Martin Kosek wrote:
On 09/24/2014 04:55 PM, Martin Basti wrote:
This probably should go to 4.0.x, 4.1 and master
It is obvious that this interface was designed this way. So you should
elaborate more on the "should" part, list use cases where current approach does
not work, link to tickets, ...
Sorry for that, I though I broke it during refactoring.
Not so fast, pardner :-) I checked with 3.3.3 and this *was* indeed changed
during your refactoring. My main point was that you should be clear about your
intents and reasons for the patch, that a mere "should" is not clear to
ACK to your patch though, works fine and restores the behavior - time to add
tests?. I just adjusted the commit message a little before pushing.
Thanks, I will add tests next week.
Freeipa-devel mailing list