On Tue, 2014-11-18 at 20:39 -0500, Simo Sorce wrote: > On Tue, 18 Nov 2014 18:00:49 -0500 > Nathaniel McCallum <npmccal...@redhat.com> wrote: > > > On Tue, 2014-11-18 at 17:58 -0500, Simo Sorce wrote: > > > On Tue, 18 Nov 2014 15:01:15 -0500 > > > Nathaniel McCallum <npmccal...@redhat.com> wrote: > > > > > > > As I see it, we're setting out a new precedent. All new ASN.1 code > > > > will take this route (which is, indeed, better). So while it is > > > > small now, it won't stay small forever. Being that we are in the > > > > business of routinely handling ASN.1 stuff, this seems to me like > > > > a sensible architecture for the future. > > > > > > Ok, I think I should have fixed all the issues you brought up. > > > > Still have a typo ("wuld") in the commit message of the first > > patch. :) > > I think I can fix it before pushing if that's the only issue ?
I'll do a more thorough review tomorrow. I haven't even looked at the third patch yet. Nathaniel _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel