On 01/22/2016 02:22 PM, Martin Babinsky wrote:
On 01/19/2016 05:56 PM, Milan Kubík wrote:
On 01/19/2016 05:31 PM, Milan Kubík wrote:
Patch attached.

This actually has a ticket opened. Patch with fixed commit message. ;)

Milan Kubik

Hi Milan,

for the step 1 installation I would rather reuse the tasks:install_master function which already does (nearly) all CLI option-related magic. You can extend its signature by adding a parameter to pass on additional options like this:

--- a/ipatests/test_integration/tasks.py
+++ b/ipatests/test_integration/tasks.py
@@ -258,7 +258,7 @@ def enable_replication_debugging(host):

-def install_master(host, setup_dns=True, setup_kra=False):
+def install_master(host, setup_dns=True, setup_kra=False, extra_args=()):
     inst = host.domain.realm.replace('.', '-')
@@ -284,6 +284,8 @@ def install_master(host, setup_dns=True, setup_kra=False):

+    args.extend(extra_args)

Thanks for the suggestion. Though, this is not possible without larger changes to tasks.install_master. The external ca test needs to skip several steps that occur in the general install task. In this case, I'd remain with customized install in the test itself.

Milan Kubik

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to