On 20.01.2016 14:38, Jan Cholasta wrote:
Hi,

On 19.1.2016 13:43, Martin Basti wrote:
New pylint version will broke our custom make-lint script again,
attached patch migrates make-lint to:
* config file
* pylint plugin
which are supported by pylint and should not have regular compatibility
issues

to test new approach run ./make-lint2

Advantages:
* compatibility with pylint
* works on both pylint-1.4.3-3.fc23.noarch and pylint-1.5.2-1.fc24.noarch
* pylint plugin works in different way than the previous custom checker.
Missing ("dynamic") attributes are added to abstract syntax tree instead
of ignoring them and all their sub-members. This makes check better,
pylint can detect more typos in tests configurations, api, env, etc..

Disadvantages:
* any new attribute in api, test config, etc.. must be added to
definition of missing members (pylint plugin) - this should not happen
too often

1) Please "mv pylint_plugins/fix_ipa_members.py pylint_plugins.py" and "rm -rf pylint_plugins/", no need for this redundant directory structure.

2) Rename pylintrc to freeipa.pylintrc so you have to always specify it explicitly with --rcfile.

3) Use the load-plugins directive in freeipa.pylintrc to load the plugins rather than --load-plugins.

4) Instead of running pylint twice, run it only once with both normal and Python 3 checks enabled:

    [MESSAGE CONTROL]
    enable=all,python3
    disable=...,no-absolute-import



Q&TODO:
* make-lint: should it be just bash script or rather python script?

IMO neither, it should be a make target (make lint).

* add dynamic detection of python files to be checked

You can use "find . -type f -executable ! -path \*/.\* ! -name \*.py\* -exec grep -lsm1 '^#!.*\bpython' \{\} \;".

* should I keep the current options from original make-lint?

No, but allow pylint options to be overridable (make lint PYLINTFLAGS="--disable=python3")

* several false positive errors I haven't been able to fix in plugin
yet, in worst case they can be locally disabled:

Disable them locally.

Honza

Updated patch attached.

Please note that make-lint script has been removed, to execute lint check use 'make lint'
From ebb80f64dd1450886de709da014fc86c2a5b159c Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Fri, 15 Jan 2016 16:58:38 +0100
Subject: [PATCH] make lint: use config file and plugin for pylint

Our custom implementation of pylint checker is often broken by
incompatible change on pylint side. Using supported solutions (config
file, pylint plugins) should avoid this issue.

The plugin adds missing (dynamic) member to classes in abstract syntax
tree generated for pylint, instead of just ignoring missing members and
all sub-members. This should improve pylint detection of typos and
missing members in api. env and test config.

make-lint python script has been removed, to run pylint execute 'make
lint'

https://fedorahosted.org/freeipa/ticket/5615
---
 Makefile                                |  13 +-
 ipalib/plugins/vault.py                 |   4 +-
 ipatests/test_ipapython/test_ipautil.py |   2 +
 make-lint                               | 351 ---------------------------
 pylint_plugins.py                       | 209 ++++++++++++++++
 pylintrc                                | 406 ++++++++++++++++++++++++++++++++
 6 files changed, 629 insertions(+), 356 deletions(-)
 delete mode 100755 make-lint
 create mode 100644 pylint_plugins.py
 create mode 100644 pylintrc

diff --git a/Makefile b/Makefile
index 7b9f95a1d06fdd73f7c1c9f1edb7fb694aaf8579..8eb1305bd23909a6f1d6a0b3f55c7d336af0d4a9 100644
--- a/Makefile
+++ b/Makefile
@@ -53,7 +53,9 @@ LIBDIR ?= /usr/lib
 
 DEVELOPER_MODE ?= 0
 ifneq ($(DEVELOPER_MODE),0)
-LINT_OPTIONS=--no-fail
+LINT_IGNORE_FAIL=true
+else
+LINT_IGNORE_FAIL=false
 endif
 
 PYTHON ?= $(shell rpm -E %__python || echo /usr/bin/python2)
@@ -124,8 +126,13 @@ client-dirs:
 	fi
 
 lint: bootstrap-autogen
-	./make-lint $(LINT_OPTIONS)
-	$(MAKE) -C install/po validate-src-strings
+	FILES=`find . \
+		-type d -exec test -e '{}/__init__.py' \; -print -prune -o \
+		-name \*.py -print -o \
+		-type f \! -path '*/.*' \! -name '*~' -exec grep -qsm1 '^#!.*\bpython' '{}' \; -print`; \
+	echo "Pylint is running, please wait ..."; \
+	PYTHONPATH=. pylint --rcfile=pylintrc $(PYLINTFLAGS) $$FILES || $(LINT_IGNORE_FAIL)
+	$(MAKE) -C install/po validate-src-strings || $(LINT_IGNORE_FAIL)
 
 
 test:
diff --git a/ipalib/plugins/vault.py b/ipalib/plugins/vault.py
index 4d8419e75770dc4c8b856560cf6c1613a132f8c0..f67dee3dd34e49d8c23475327afac281741f3aa7 100644
--- a/ipalib/plugins/vault.py
+++ b/ipalib/plugins/vault.py
@@ -1651,7 +1651,7 @@ class vault_archive(PKQuery, Local):
         session_key = slot.key_gen(mechanism, None, key_length)
 
         # wrap session key with transport certificate
-        public_key = nss_transport_cert.subject_public_key_info.public_key
+        public_key = nss_transport_cert.subject_public_key_info.public_key  # pylint: disable=no-member
         wrapped_session_key = nss.pub_wrap_sym_key(mechanism,
                                                    public_key,
                                                    session_key)
@@ -1855,7 +1855,7 @@ class vault_retrieve(PKQuery, Local):
         session_key = slot.key_gen(mechanism, None, key_length)
 
         # wrap session key with transport certificate
-        public_key = nss_transport_cert.subject_public_key_info.public_key
+        public_key = nss_transport_cert.subject_public_key_info.public_key  # pylint: disable=no-member
         wrapped_session_key = nss.pub_wrap_sym_key(mechanism,
                                                    public_key,
                                                    session_key)
diff --git a/ipatests/test_ipapython/test_ipautil.py b/ipatests/test_ipapython/test_ipautil.py
index 1197d5ce552dc2c244d195175ef008d7b3a21c02..8a437f83ed26b47c5bd470b4e7cdbe7a567af707 100644
--- a/ipatests/test_ipapython/test_ipautil.py
+++ b/ipatests/test_ipapython/test_ipautil.py
@@ -384,6 +384,8 @@ class TestTimeParser(object):
         nose.tools.assert_equal(800000, time.microsecond)
 
     def test_time_zones(self):
+        # pylint: disable=no-member
+
         timestr = "20051213141205Z"
 
         time = ipautil.parse_generalized_time(timestr)
diff --git a/make-lint b/make-lint
deleted file mode 100755
index cbc7d285a9d8426c4eea609b6e3f84291e31cd6a..0000000000000000000000000000000000000000
--- a/make-lint
+++ /dev/null
@@ -1,351 +0,0 @@
-#!/usr/bin/python2
-#
-# Authors:
-#   Jakub Hrozek <jhro...@redhat.com>
-#   Jan Cholasta <jchol...@redhat.com>
-#
-# Copyright (C) 2011  Red Hat
-# see file 'COPYING' for use and warranty information
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-from __future__ import print_function
-
-import os
-import sys
-from optparse import OptionParser
-from fnmatch import fnmatch, fnmatchcase
-import subprocess
-
-try:
-    from pylint import checkers
-    from pylint.lint import PyLinter
-    from pylint.checkers.typecheck import TypeChecker
-    from pylint.checkers.utils import safe_infer
-    from astroid import Class, Instance, Module, InferenceError, Function
-    from pylint.reporters.text import TextReporter
-except ImportError:
-    print("To use {0}, please install pylint.".format(sys.argv[0]), file=sys.stderr)
-    sys.exit(32)
-
-# File names to ignore when searching for python source files
-IGNORE_FILES = ('.*', '*~', '*.in', '*.pyc', '*.pyo')
-IGNORE_PATHS = (
-    'build', 'rpmbuild', 'dist', 'install/po/test_i18n.py', 'lite-server.py')
-
-class IPATypeChecker(TypeChecker):
-    NAMESPACE_ATTRS = ['Command', 'Object', 'Method', 'Backend', 'Updater',
-        'Advice']
-    LOGGING_ATTRS = ['log', 'debug', 'info', 'warning', 'error', 'exception',
-        'critical']
-
-    # 'class or module': ['generated', 'properties']
-    ignore = {
-        # Python standard library & 3rd party classes
-        'socket._socketobject': ['sendall'],
-        # should be 'subprocess.Popen'
-        '.Popen': ['stdin', 'stdout', 'stderr', 'pid', 'returncode', 'poll',
-            'wait', 'communicate'],
-        'urlparse.ResultMixin': ['scheme', 'netloc', 'path', 'query',
-            'fragment', 'username', 'password', 'hostname', 'port'],
-        'urlparse.ParseResult': ['params'],
-        'pytest': ['fixture', 'raises', 'skip', 'yield_fixture', 'mark', 'fail'],
-        'unittest.case': ['assertEqual', 'assertRaises'],
-        'nose.tools': ['assert_equal', 'assert_raises'],
-        'datetime.tzinfo': ['houroffset', 'minoffset', 'utcoffset', 'dst'],
-        'nss.nss.subject_public_key_info': ['public_key'],
-
-        # IPA classes
-        'ipalib.base.NameSpace': ['add', 'mod', 'del', 'show', 'find'],
-        'ipalib.cli.Collector': ['__options'],
-        'ipalib.config.Env': ['*'],
-        'ipalib.parameters.Param': ['cli_name', 'cli_short_name', 'label',
-            'default', 'doc', 'required', 'multivalue', 'primary_key',
-            'normalizer', 'default_from', 'autofill', 'query', 'attribute',
-            'include', 'exclude', 'flags', 'hint', 'alwaysask', 'sortorder',
-            'csv', 'option_group'],
-        'ipalib.parameters.Bool': ['truths', 'falsehoods'],
-        'ipalib.parameters.Data': ['minlength', 'maxlength', 'length',
-            'pattern', 'pattern_errmsg'],
-        'ipalib.parameters.Str': ['noextrawhitespace'],
-        'ipalib.parameters.Password': ['confirm'],
-        'ipalib.parameters.File': ['stdin_if_missing'],
-        'ipalib.plugins.dns.DNSRecord': ['validatedns', 'normalizedns'],
-        'ipalib.parameters.Enum': ['values'],
-        'ipalib.parameters.Number': ['minvalue', 'maxvalue'],
-        'ipalib.parameters.Decimal': ['precision', 'exponential',
-            'numberclass'],
-        'ipalib.parameters.DNSNameParam': ['only_absolute', 'only_relative'],
-        'ipalib.plugable.API': NAMESPACE_ATTRS + LOGGING_ATTRS,
-        'ipalib.plugable.Plugin': ['api', 'env'] + NAMESPACE_ATTRS +
-            LOGGING_ATTRS,
-        'ipalib.session.AuthManager': LOGGING_ATTRS,
-        'ipalib.session.SessionAuthManager': LOGGING_ATTRS,
-        'ipalib.session.SessionManager': LOGGING_ATTRS,
-        'ipaserver.install.ldapupdate.LDAPUpdate': LOGGING_ATTRS,
-        'ipaserver.rpcserver.KerberosSession': ['api'] + LOGGING_ATTRS,
-        'ipatests.test_integration.base.IntegrationTest': [
-            'domain', 'master', 'replicas', 'clients', 'ad_domains']
-    }
-
-    def _related_classes(self, klass):
-        yield klass
-        for base in klass.ancestors():
-            yield base
-
-    def _class_full_name(self, klass):
-        return klass.root().name + '.' + klass.name
-
-    def _find_ignored_attrs(self, owner):
-        attrs = []
-        for klass in self._related_classes(owner):
-            name = self._class_full_name(klass)
-            if name in self.ignore:
-                attrs += self.ignore[name]
-        return attrs
-
-    def visit_getattr(self, node):
-        try:
-            inferred = list(node.expr.infer())
-        except InferenceError:
-            inferred = []
-
-        for owner in inferred:
-            if isinstance(owner, Module):
-                if node.attrname in self.ignore.get(owner.name, ()):
-                    return
-
-            elif isinstance(owner, Class) or type(owner) is Instance:
-                ignored = self._find_ignored_attrs(owner)
-                for pattern in ignored:
-                    if fnmatchcase(node.attrname, pattern):
-                        return
-
-        super(IPATypeChecker, self).visit_getattr(node)
-
-    def visit_callfunc(self, node):
-        called = safe_infer(node.func)
-        if isinstance(called, Function):
-            if called.name in self.ignore.get(called.root().name, []):
-                return
-
-        super(IPATypeChecker, self).visit_callfunc(node)
-
-class IPALinter(PyLinter):
-    ignore = (TypeChecker,)
-
-    def __init__(self):
-        super(IPALinter, self).__init__()
-
-        self.missing = set()
-
-    def register_checker(self, checker):
-        if type(checker) in self.ignore:
-            return
-        super(IPALinter, self).register_checker(checker)
-
-    def add_message(self, msg_id, line=None, node=None, args=None, confidence=None):
-        if line is None and node is not None:
-            line = node.fromlineno
-
-        # Record missing packages
-        if msg_id == 'F0401' and self.is_message_enabled(msg_id, line):
-            self.missing.add(args)
-
-        super(IPALinter, self).add_message(msg_id, line, node, args)
-
-def find_files(path, basepath):
-    entries = os.listdir(path)
-
-    # If this directory is a python package, look no further
-    if '__init__.py' in entries:
-        return [path]
-
-    result = []
-    for filename in entries:
-        filepath = os.path.join(path, filename)
-
-        for pattern in IGNORE_FILES:
-            if fnmatch(filename, pattern):
-                filename = None
-                break
-        if filename is None:
-            continue
-
-        for pattern in IGNORE_PATHS:
-            patpath = os.path.join(basepath, pattern).replace(os.sep, '/')
-            if filepath == patpath:
-                filename = None
-                break
-        if filename is None:
-            continue
-
-        if os.path.islink(filepath):
-            continue
-
-        # Recurse into subdirectories
-        if os.path.isdir(filepath):
-            result += find_files(filepath, basepath)
-            continue
-
-        # Add all *.py files
-        if filename.endswith('.py'):
-            result.append(filepath)
-            continue
-
-        # Add any other files beginning with a shebang and having
-        # the word "python" on the first line
-        file = open(filepath, 'r')
-        line = file.readline(128)
-        file.close()
-
-        if line[:2] == '#!' and line.find('python') >= 0:
-            result.append(filepath)
-
-    return result
-
-def main():
-    optparser = OptionParser()
-    optparser.add_option('--no-fail', help='report success even if errors were found',
-        dest='fail', default=True, action='store_false')
-    optparser.add_option('--enable-noerror', help='enable warnings and other non-error messages',
-        dest='errors_only', default=True, action='store_false')
-    optparser.add_option('--no-py3k', help='Do not check for Python 3 porting issues',
-        dest='py3k', default=True, action='store_false')
-    optparser.add_option('--no-lint', help='Skip the main lint check',
-        dest='do_lint', default=True, action='store_false')
-
-    options, args = optparser.parse_args()
-    cwd = os.getcwd()
-
-    if len(args) == 0:
-        files = find_files(cwd, cwd)
-    else:
-        files = args
-
-    for filename in files:
-        dirname = os.path.dirname(filename)
-        if dirname not in sys.path:
-            sys.path.insert(0, dirname)
-
-    linter = IPALinter()
-    checkers.initialize(linter)
-    linter.register_checker(IPATypeChecker(linter))
-
-    if options.errors_only:
-        linter.set_option('disable', 'I')
-
-        linter.set_option('enable', 'F')
-        linter.set_option('disable', 'import-error')
-
-        linter.set_option('enable', 'E')
-
-        linter.set_option('enable', 'W')
-        linter.set_option('disable', 'abstract-method')
-        linter.set_option('disable', 'anomalous-backslash-in-string')
-        linter.set_option('disable', 'arguments-differ')
-        linter.set_option('disable', 'attribute-defined-outside-init')
-        linter.set_option('disable', 'bad-builtin')
-        linter.set_option('disable', 'bad-indentation')
-        linter.set_option('disable', 'bare-except')
-        linter.set_option('disable', 'broad-except')
-        linter.set_option('disable', 'dangerous-default-value')
-        linter.set_option('disable', 'eval-used')
-        linter.set_option('disable', 'exec-used')
-        linter.set_option('disable', 'fixme')
-        linter.set_option('disable', 'global-statement')
-        linter.set_option('disable', 'global-variable-not-assigned')
-        linter.set_option('disable', 'global-variable-undefined')
-        linter.set_option('disable', 'no-init')
-        linter.set_option('disable', 'pointless-except')
-        linter.set_option('disable', 'pointless-statement')
-        linter.set_option('disable', 'pointless-string-statement')
-        linter.set_option('disable', 'protected-access')
-        linter.set_option('disable', 'redefine-in-handler')
-        linter.set_option('disable', 'redefined-builtin')
-        linter.set_option('disable', 'redefined-outer-name')
-        linter.set_option('disable', 'reimported')
-        linter.set_option('disable', 'relative-import')
-        linter.set_option('disable', 'super-init-not-called')
-        linter.set_option('disable', 'undefined-loop-variable')
-        linter.set_option('disable', 'unnecessary-lambda')
-        linter.set_option('disable', 'unnecessary-semicolon')
-        linter.set_option('disable', 'unused-argument')
-        linter.set_option('disable', 'unused-variable')
-        linter.set_option('disable', 'useless-else-on-loop')
-
-        linter.set_option('enable', 'C')
-        linter.set_option('disable', 'bad-classmethod-argument')
-        linter.set_option('disable', 'bad-continuation')
-        linter.set_option('disable', 'bad-mcs-classmethod-argument')
-        linter.set_option('disable', 'bad-mcs-method-argument')
-        linter.set_option('disable', 'bad-whitespace')
-        linter.set_option('disable', 'blacklisted-name')
-        linter.set_option('disable', 'invalid-name')
-        linter.set_option('disable', 'line-too-long')
-        linter.set_option('disable', 'missing-docstring')
-        linter.set_option('disable', 'multiple-imports')
-        linter.set_option('disable', 'multiple-statements')
-        linter.set_option('disable', 'old-style-class')
-        linter.set_option('disable', 'superfluous-parens')
-        linter.set_option('disable', 'too-many-lines')
-        linter.set_option('disable', 'unidiomatic-typecheck')
-
-        linter.set_option('disable', 'R')
-
-    linter.set_reporter(TextReporter())
-    linter.set_option('msg-template',
-                        '{path}:{line}: [{msg_id}({symbol}), {obj}] {msg})')
-    linter.set_option('reports', False)
-    linter.set_option('persistent', False)
-    linter.set_option('disable', 'python3')
-
-    if options.do_lint:
-        linter.check(files)
-
-        if linter.msg_status != 0:
-            print("""
-===============================================================================
-Errors were found during the static code check.
-""", file=sys.stderr)
-
-            if len(linter.missing) > 0:
-                print("There are some missing imports:", file=sys.stderr)
-                for mod in sorted(linter.missing):
-                    print("    " + mod, file=sys.stderr)
-                print("""
-Please make sure all of the required and optional (python-gssapi, python-rhsm)
-python packages are installed.
-""", file=sys.stderr)
-
-                print("""\
-If you are certain that any of the reported errors are false positives, please
-mark them in the source code according to the pylint documentation.
-===============================================================================
-""", file=sys.stderr)
-
-        if options.fail and linter.msg_status != 0:
-            return linter.msg_status
-
-    if options.py3k:
-        args = ['pylint', '--py3k', '-d', 'no-absolute-import', '--reports=n']
-        args.extend(files)
-        returncode = subprocess.call(args)
-        if options.fail and returncode != 0:
-            return returncode
-
-    return 0
-
-if __name__ == "__main__":
-    sys.exit(main())
diff --git a/pylint_plugins.py b/pylint_plugins.py
new file mode 100644
index 0000000000000000000000000000000000000000..91f7fcaeb9e36030b301a7dc51c9a87cc2e642ec
--- /dev/null
+++ b/pylint_plugins.py
@@ -0,0 +1,209 @@
+#
+# Copyright (C) 2015  FreeIPA Contributors see COPYING for license
+#
+
+from __future__ import print_function
+
+import copy
+import sys
+
+from astroid import MANAGER
+from astroid import scoped_nodes
+
+
+def register(linter):
+    pass
+
+
+def _warning_already_exists(cls, member):
+    print(
+        "WARNING: member '{member}' in '{cls}' already exists".format(
+            cls="{}.{}".format(cls.root().name, cls.name), member=member),
+        file=sys.stderr
+    )
+
+
+def fake_class(name_or_class_obj, members=()):
+    if isinstance(name_or_class_obj, scoped_nodes.Class):
+        cl = name_or_class_obj
+    else:
+        cl = scoped_nodes.Class(name_or_class_obj, None)
+
+    for m in members:
+        if isinstance(m, str):
+            if m in cl.locals:
+                _warning_already_exists(cl, m)
+            else:
+                cl.locals[m] = [scoped_nodes.Class(m, None)]
+        elif isinstance(m, dict):
+            for key, val in m.items():
+                assert isinstance(key, str), "key must be string"
+                if key in cl.locals:
+                    _warning_already_exists(cl, key)
+                    fake_class(cl.locals[key], val)
+                else:
+                    cl.locals[key] = [fake_class(key, val)]
+        else:
+            # here can be used any astroid type
+            if m.name in cl.locals:
+                _warning_already_exists(cl, m.name)
+            else:
+                cl.locals[m.name] = [copy.copy(m)]
+    return cl
+
+
+fake_backend = {'Backend': [
+    {'wsgi_dispatch': ['mount']},
+]}
+
+NAMESPACE_ATTRS = ['Command', 'Object', 'Method', fake_backend, 'Updater',
+                   'Advice']
+fake_api_env = {'env': [
+    'host',
+    'realm',
+    'session_auth_duration',
+    'session_duration_type',
+]}
+
+# this is due ipaserver.rpcserver.KerberosSession where api is undefined
+fake_api = {'api': [fake_api_env] + NAMESPACE_ATTRS}
+
+_LOGGING_ATTRS = ['debug', 'info', 'warning', 'error', 'exception',
+                  'critical']
+LOGGING_ATTRS = [
+    {'log': _LOGGING_ATTRS},
+] + _LOGGING_ATTRS
+
+# 'class': ['generated', 'properties']
+ipa_class_members = {
+    # Python standard library & 3rd party classes
+    'socket._socketobject': ['sendall'],
+
+    # IPA classes
+    'ipalib.base.NameSpace': [
+        'add',
+        'mod',
+        'del',
+        'show',
+        'find'
+    ],
+    'ipalib.cli.Collector': ['__options'],
+    'ipalib.config.Env': [
+        {'__d': ['get']},
+        {'__done': ['add']},
+        'xmlrpc_uri',
+        'validate_api',
+        'startup_traceback',
+        'verbose'
+    ] + LOGGING_ATTRS,
+    'ipalib.parameters.Param': [
+        'cli_name',
+        'cli_short_name',
+        'label',
+        'default',
+        'doc',
+        'required',
+        'multivalue',
+        'primary_key',
+        'normalizer',
+        'default_from',
+        'autofill',
+        'query',
+        'attribute',
+        'include',
+        'exclude',
+        'flags',
+        'hint',
+        'alwaysask',
+        'sortorder',
+        'csv',
+        'option_group',
+     ],
+    'ipalib.parameters.Bool': [
+        'truths',
+        'falsehoods'],
+    'ipalib.parameters.Data': [
+        'minlength',
+        'maxlength',
+        'length',
+        'pattern',
+        'pattern_errmsg',
+    ],
+    'ipalib.parameters.Str': ['noextrawhitespace'],
+    'ipalib.parameters.Password': ['confirm'],
+    'ipalib.parameters.File': ['stdin_if_missing'],
+    'ipalib.plugins.dns.DNSRecord': [
+        'validatedns',
+        'normalizedns',
+    ],
+    'ipalib.parameters.Enum': ['values'],
+    'ipalib.parameters.Number': [
+        'minvalue',
+        'maxvalue',
+    ],
+    'ipalib.parameters.Decimal': [
+        'precision',
+        'exponential',
+        'numberclass',
+    ],
+    'ipalib.parameters.DNSNameParam': [
+        'only_absolute',
+        'only_relative',
+    ],
+    'ipalib.plugable.API': [
+        fake_api_env,
+    ] + NAMESPACE_ATTRS + LOGGING_ATTRS,
+    'ipalib.plugable.Plugin': [
+        'Object',
+        'Method',
+        'Updater',
+        'Advice',
+    ] + LOGGING_ATTRS,
+    'ipalib.session.AuthManager': LOGGING_ATTRS,
+    'ipalib.session.SessionAuthManager': LOGGING_ATTRS,
+    'ipalib.session.SessionManager': LOGGING_ATTRS,
+    'ipaserver.install.ldapupdate.LDAPUpdate': LOGGING_ATTRS,
+    'ipaserver.rpcserver.KerberosSession': [
+        fake_api,
+    ] + LOGGING_ATTRS,
+    'ipatests.test_integration.base.IntegrationTest': [
+        'domain',
+        {'master': [
+            {'config': [
+                {'dirman_password': dir(str)},
+                {'admin_password': dir(str)},
+                {'admin_name': dir(str)},
+                {'dns_forwarder': dir(str)},
+                {'test_dir': dir(str)},
+                {'ad_admin_name': dir(str)},
+                {'ad_admin_password': dir(str)},
+            ]},
+            {'domain': [
+                {'realm': dir(str)},
+                {'name': dir(str)},
+            ]},
+            'hostname',
+            'ip',
+            'collect_log',
+            {'run_command': [
+                {'stdout_text': dir(str)},
+                'stderr_text',
+                'returncode',
+            ]},
+            {'transport': ['put_file']},
+            'put_file_contents',
+            'get_file_contents',
+        ]},
+        'replicas',
+        'clients',
+        'ad_domains',
+    ]
+}
+
+
+def fix_ipa_classes(cls):
+    class_name_with_module = "{}.{}".format(cls.root().name, cls.name)
+    if class_name_with_module in ipa_class_members:
+        fake_class(cls, ipa_class_members[class_name_with_module])
+
+MANAGER.register_transform(scoped_nodes.Class, fix_ipa_classes)
diff --git a/pylintrc b/pylintrc
new file mode 100644
index 0000000000000000000000000000000000000000..df3e18fc835e36e92a9655d35e9fe1bb885c85f7
--- /dev/null
+++ b/pylintrc
@@ -0,0 +1,406 @@
+[MASTER]
+
+# Specify a configuration file.
+#rcfile=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Add files or directories to the blacklist. They should be base names, not
+# paths.
+ignore=CVS
+
+# Pickle collected data for later comparisons.
+persistent=no
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=pylint_plugins
+
+# Use multiple processes to speed up Pylint.
+jobs=1
+
+# Allow loading of arbitrary C extensions. Extensions are imported into the
+# active Python interpreter and may run arbitrary code.
+unsafe-load-any-extension=no
+
+# A comma-separated list of package or module names from where C extensions may
+# be loaded. Extensions are loading into the active Python interpreter and may
+# run arbitrary code
+extension-pkg-whitelist=
+
+# Allow optimization of some AST trees. This will activate a peephole AST
+# optimizer, which will apply various small optimizations. For instance, it can
+# be used to obtain the result of joining multiple strings with the addition
+# operator. Joining a lot of strings can lead to a maximum recursion error in
+# Pylint and this flag can prevent that. It has one side effect, the resulting
+# AST will be different than the one from reality.
+optimize-ast=no
+
+
+[MESSAGES CONTROL]
+
+# Only show warnings with the listed confidence levels. Leave empty to show
+# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
+confidence=
+
+enable=
+    all,
+    python3
+
+disable=
+    R,
+    I,
+    invalid-name,
+    import-error,
+    abstract-method,
+    anomalous-backslash-in-string,
+    arguments-differ,
+    attribute-defined-outside-init,
+    bad-builtin,
+    bad-indentation,
+    bare-except,
+    broad-except,
+    dangerous-default-value,
+    eval-used,
+    exec-used,
+    fixme,
+    global-statement,
+    global-variable-not-assigned,
+    global-variable-undefined,
+    no-init,
+    pointless-except,
+    pointless-statement,
+    pointless-string-statement,
+    protected-access,
+    redefine-in-handler,
+    redefined-builtin,
+    redefined-outer-name,
+    reimported,
+    relative-import,
+    super-init-not-called,
+    undefined-loop-variable,
+    unnecessary-lambda,
+    unnecessary-semicolon,
+    unused-argument,
+    unused-variable,
+    useless-else-on-loop,
+    bad-classmethod-argument,
+    bad-continuation,
+    bad-mcs-classmethod-argument,
+    bad-mcs-method-argument,
+    bad-whitespace,
+    blacklisted-name,
+    invalid-name,
+    line-too-long,
+    missing-docstring,
+    multiple-imports,
+    multiple-statements,
+    old-style-class,
+    superfluous-parens,
+    too-many-lines,
+    unidiomatic-typecheck,
+    no-absolute-import
+
+
+[REPORTS]
+
+# Set the output format. Available formats are text, parseable, colorized, msvs
+# (visual studio) and html. You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=colorized
+
+# Put messages in a separate file for each module / package specified on the
+# command line instead of printing them on stdout. Reports (if any) will be
+# written in a file name "pylint_global.[txt|html]".
+files-output=no
+
+# Tells whether to display a full report or only the messages
+reports=no
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (RP0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Template used to display messages. This is a python new-style format string
+# used to format the message information. See doc for all details
+msg-template='{path}:{line}: [{msg_id}({symbol}), {obj}] {msg})'
+
+
+[SIMILARITIES]
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+# Ignore imports when computing similarities.
+ignore-imports=no
+
+
+[LOGGING]
+
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
+
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus existing member attributes cannot be deduced by static analysis
+ignored-modules=
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=SQLObject
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed. Python regular
+# expressions are accepted.
+generated-members=REQUEST,acl_users,aq_parent
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO
+
+
+[SPELLING]
+
+# Spelling dictionary name. Available dictionaries: none. To make it working
+# install python-enchant package.
+spelling-dict=
+
+# List of comma separated words that should not be checked.
+spelling-ignore-words=
+
+# A path to a file that contains private dictionary; one word per line.
+spelling-private-dict-file=
+
+# Tells whether to store unknown words to indicated private dictionary in
+# --spelling-private-dict-file option instead of raising a message.
+spelling-store-unknown-words=no
+
+
+[FORMAT]
+
+# Maximum number of characters on a single line.
+max-line-length=100
+
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+# List of optional constructs for which whitespace checking is disabled
+no-space-check=trailing-comma,dict-separator
+
+# Maximum number of lines in a module
+max-module-lines=1000
+
+# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
+# tab).
+indent-string='    '
+
+# Number of spaces of indent required inside a hanging or continued line.
+indent-after-paren=4
+
+# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
+expected-line-ending-format=
+
+
+[BASIC]
+
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=map,filter,input
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,ex,Run,_
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
+
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
+
+# Regular expression matching correct function names
+function-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for function names
+function-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct variable names
+variable-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for variable names
+variable-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Regular expression matching correct attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for attribute names
+attr-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct argument names
+argument-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for argument names
+argument-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression matching correct method names
+method-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for method names
+method-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression which should only match function or class names that do
+# not require a docstring.
+no-docstring-rgx=__.*__
+
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
+
+
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=_$|dummy
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
+
+# List of strings which can identify a callback function by name. A callback
+# name must start or end with one of those strings.
+callbacks=cb_,_cb
+
+
+[CLASSES]
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+# List of member names, which should be excluded from the protected access
+# warning.
+exclude-protected=_asdict,_fields,_replace,_source,_make
+
+
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of branch for function / method body
+max-branches=12
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+
+[IMPORTS]
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=regsub,TERMIOS,Bastion,rexec
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=Exception
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to