On 05/24/2016 04:29 PM, Nathaniel McCallum wrote: > Using a pragma instead of guards is easier to write, less error prone > and avoids name clashes (a source of very subtle bugs). This pragma > is supported on almost all compilers, including all the compilers we > care about: https://en.wikipedia.org/wiki/Pragma_once#Portability. > > >
Makes sense to me. I did not test, just saw a potential typo/omission: --- a/daemons/ipa-otpd/internal.h +++ b/daemons/ipa-otpd/internal.h @@ -20,9 +20,6 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -#ifndef INTERNAL_H_ -#define INTERNAL_H_ - ... no pragma there. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code