On 05/20/2016 03:00 PM, Martin Basti wrote:


On 19.05.2016 13:34, Stanislav Laznicka wrote:

Also, I tried to upgrade from 4.2.4 to 4.3.1 and it seems that it might be necessary to start the service even earlier in the upgrade logic. Attached is the trace that occurred during the upgrade.

I sent the whole log earlier accidentally, hopefully it will not arrive here as well.

On 05/19/2016 11:10 AM, Stanislav Laznicka wrote:

NACK, see my comments below

+    # following upgrade steps require running CA
This is a nitpicky nitpick but could you please change this comment for # the following ...
Took me a while to understand what you were trying to say here.
+    if ca_running and not ca.is_running():
+        ca.stop('pki-tomcat')
+    elif not ca_running and ca.is_running():
+        ca.start('pki-tomcat')
+
You should swap ca.stop and ca.start here, you're stopping the service when it's stopped and starting it when it's already running.
Shame, shame, shame on me.


On 05/12/2016 04:34 PM, Martin Basti wrote:
Patch attached.

https://fedorahosted.org/freeipa/ticket/5868








I moved starting of CA to the earlier phase and swapped start/stop to correct order.

Patch attached.
Seems to work as expected now. ACK.
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to