On 05/31/2016 03:57 PM, Nathaniel McCallum wrote:
> On Tue, 2016-05-31 at 15:25 +0200, Petr Vobornik wrote:
>> On 05/31/2016 02:49 PM, Nathaniel McCallum wrote:
>>> On Mon, 2016-05-30 at 19:08 +0300, Alexander Bokovoy wrote:
>>>> On Mon, 30 May 2016, Petr Vobornik wrote:
>>>>> On 05/27/2016 06:00 PM, Nathaniel McCallum wrote:
>>>>>> Pavel, since we made the change here from a StrEnum to a Str,
>>>>>> we
>>>>>> need
>>>>>> to update the UI patch accordingly.
>>>>>
>>>>> How should admin know what to write there intuitively?
>>>>>
>>>>> Shouldn't Web UI or CLI advertise the indicators supported by
>>>>> IPA?
>>>>> E.g.
>>>>> CLI in doc string. Web UI might even combine checkboxes (otp,
>>>>> radius)
>>>>> with textbox.
>>>> That would be better, I think. We still need to keep the API with
>>>> a
>>>> free
>>>> text field but Web UI, of course, should provide some pre-defined
>>>> labels.
>>>
>>> I *think* this means that this patch doesn't need any changes. Is
>>> that
>>> correct? If so, can I get a review? :)
>>>
>>
>> I meant that the param's 'doc' attribute can get the supported
>> values.
>> So that they would be shown in `ipa service-mod --help`
>>
>> Btw, the `required: false` and `multivalued: true` can be simplified
>> into Str('krbprincipalauthind*')
>
> I fixed the doc string as well as the verbosity. I also rebased against
> the current master.
>
ACK
master:
* 4ded2ffc161ec649ba1ccf8d0b528d24028080df Enable service authentication
indicator management
--
Petr Vobornik
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
