On (08/06/16 14:09), Petr Vobornik wrote: >On 06/08/2016 10:07 AM, Petr Spacek wrote: >> On 7.6.2016 15:11, Stanislav Laznicka wrote: >>> Hello, >>> >>> Thank you for your patch. As the thin-client patches were pushed in the >>> meantime, the patch won't apply. Could you please send a rebased version? >>> >>> Also, I have a few comments to the patch: >>> >>> 1) I think that the commit message should be rather a brief conclusion to >>> the >>> changes made in the commit. This could help for faster orientation in the >>> changes that were made to a certain part of code should you be searching >>> for a >>> bug introduced by a commit. Should some more info be required, it can be >>> added >>> to the ticket. Could you therefore shorten the commit message? >> >> (My personal opinion, no golden standard.) >> >> Honestly I disagree with Standa. Yes, the commit message seems to be a bit >> long but *tickets* are not the best place to put *technical* information >> into. >> >> Tickets are planning tool but keep in mind that Trac may/will vanish one day >> and all we will have will be (Git?) repo. > >+1 > >The commit message is very good and honestly I'd like to see more of >such commit messages. > Regarding to commit message.
I like recommendation about git commit message from Openstack wiki https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages We can at least inspire. IMHO longer commit message is always better. LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
