On 20.06.2016 18:32, Petr Spacek wrote:
On 20.6.2016 18:05, Martin Basti wrote:
On 20.06.2016 16:57, Petr Spacek wrote:
Hello,
DNS: Warn about restart when default TTL setting DNS is changed
bind-dyndb-ldap 10.0 has to be restarted after each change to default
TTL.
https://fedorahosted.org/freeipa/ticket/2956
DNS: Support default TTL setting for master DNS zones
https://fedorahosted.org/freeipa/ticket/2956
Thank you for patches, but I have a few comments
TTL patch:
1)
VERSION - please put short note why API was incremented
2)
60ipadns.ldif - please keep ordered attr definitions by OID
3)
You missed ACI for updating
Warning patch: LGTM
Thank you very much for review!
Here is revised version.
I cannot apply patches on current master, even with git am -3
Martin^2
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
