On 21.06.2016 11:55, Petr Spacek wrote:
On 21.6.2016 10:00, Petr Spacek wrote:
On 20.6.2016 19:15, Martin Basti wrote:
On 20.06.2016 18:32, Petr Spacek wrote:
On 20.6.2016 18:05, Martin Basti wrote:
On 20.06.2016 16:57, Petr Spacek wrote:
Hello,
DNS: Warn about restart when default TTL setting DNS is changed
bind-dyndb-ldap 10.0 has to be restarted after each change to default
TTL.
https://fedorahosted.org/freeipa/ticket/2956
DNS: Support default TTL setting for master DNS zones
https://fedorahosted.org/freeipa/ticket/2956
Thank you for patches, but I have a few comments
TTL patch:
1)
VERSION - please put short note why API was incremented
2)
60ipadns.ldif - please keep ordered attr definitions by OID
3)
You missed ACI for updating
Warning patch: LGTM
Thank you very much for review!
Here is revised version.
I cannot apply patches on current master, even with git am -3
I do not what could be problem, there was only "standard" conflict on VERSION.
Anyway, there are patches rebased to current master.
... and now with results from makeaci :-)
ACK
master:
* eefdcc6b076e4305a14f231865636d46e4f16cf5 DNS: Support default TTL
setting for master DNS zones
* f2974b8d965c14247d8a9d03e0df3b5183e20d76 DNS: Warn about restart when
default TTL setting DNS is changed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
