On 06/29/2016 05:42 PM, Petr Vobornik wrote:
On 06/24/2016 12:40 PM, Pavel Vomacka wrote:

please review attached patches, they add 'Delete Server' button.

1. there is a whitespace warning while applying patch 63.

2. It breaks expectation of no_init.
Instead of
   var that = IPA.details_facet(spec);
   var that = IPA.details_facet(spec, no_init);

Then rename:
   that.init_facet = function() {
   that.init_servers_facet = function() {

Add there at beginning:

3. IPA.action and IPA.delete_action has the functionality of
server_delete_action build-in, including redirection to server search
page which is missing in this patch.

Updated patch with the issues fixed is attached.

I did not test final version of the patch because my testing env. died.
Thank you, everything works well.


Pavel^3 Vomacka

Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to