Hi,

On 26.7.2016 16:09, Martin Basti wrote:



On 22.07.2016 00:14, Ariel Barria wrote:
Hello everyone.

I send patch for review.

NACK, six.u() is supposed to be used on string literals *only* [1].

A proper fix would be something like:

    value = self.to_text()
    if not isinstance(value, unicode):
        value = value.decode('ascii')
    return value


Regards,



Thank you,

I will look on this, for some reason we received your e-mail just today
(2016-07-26)

Honza

[1] <https://pythonhosted.org/six/#six.u>

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to